Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original parser error to rollup error #3176

merged 4 commits into from Oct 20, 2019


Copy link

@gribnoysup gribnoysup commented Oct 19, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


As discussed in #3149 this PR adds parserError property to rollup error to give more useful information to the end users of the library. No new tests were added, but all tests related to parser errors were updated with the new property

Copy link

@lukastaegert lukastaegert left a comment

Thanks a lot, looks good!

Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #3176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3176   +/-   ##
  Coverage    90.2%   90.2%           
  Files         165     165           
  Lines        5910    5910           
  Branches     1800    1800           
  Hits         5331    5331           
  Misses        350     350           
  Partials      229     229
Impacted Files Coverage Δ
src/Module.ts 94.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06047fc...27f49b4. Read the comment docs.

@lukastaegert lukastaegert merged commit f99c7e4 into rollup:master Oct 20, 2019
7 checks passed
@gribnoysup gribnoysup deleted the issue-3149-acorn-errors branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants