Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollupOptions accept output as array #3184

Merged
merged 2 commits into from Oct 23, 2019
Merged

Conversation

imcotton
Copy link
Contributor

@imcotton imcotton commented Oct 22, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

ref:

const output = config.output;
const normalizedOutputOptions = Array.isArray(output) ? output : output ? [output] : [];

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #3184 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3184   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files         165      165           
  Lines        5905     5905           
  Branches     1797     1797           
=======================================
  Hits         5326     5326           
  Misses        350      350           
  Partials      229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae509d...1aa9736. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Makes sense, thanks!

@lukastaegert lukastaegert merged commit e24bc46 into rollup:master Oct 23, 2019
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants