Use correct file names when writing sourcemaps for multiple outputs using the "dir" option #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3440 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 171 171
Lines 5840 5841 +1
Branches 1723 1723
=======================================
+ Hits 5549 5550 +1
Misses 157 157
Partials 134 134
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3439
Description
The issue was that Rollup mutates the generated chunk objects when writing multiple outputs, overwriting the chunk ids in the process. When using a config file, writing multiple outputs is interleaved. As the sourcemapfile is using the chunk id and is generated at the end, an overwritten chunk id is used. This is fixed for now by storing the chunk id in a local variable.