Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preserveModulesRoot path on Windows #3791

Merged
merged 1 commit into from Sep 21, 2020
Merged

Fix preserveModulesRoot path on Windows #3791

merged 1 commit into from Sep 21, 2020

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Sep 21, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (Existing tests were red on Windows) (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Unfortunately as Windows tests do not run on forks, there was a Windows issue that was not noticed

@rollup-bot
Copy link

@rollup-bot rollup-bot commented Sep 21, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-windows-path

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13030

@codecov
Copy link

@codecov codecov bot commented Sep 21, 2020

Codecov Report

Merging #3791 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3791   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         185      185           
  Lines        6478     6478           
  Branches     1877     1877           
=======================================
  Hits         6286     6286           
  Misses        101      101           
  Partials       91       91           
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2172df...318377d. Read the comment docs.

@lukastaegert lukastaegert merged commit b7bb660 into master Sep 21, 2020
9 checks passed
9 checks passed
14 (Windows)
Details
12 (Windows)
Details
10 (Windows)
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v14-latest Your tests passed on CircleCI!
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@lukastaegert lukastaegert deleted the fix-windows-path branch Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.