Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SystemJS default variable conflict #3796

Merged
merged 1 commit into from Sep 24, 2020
Merged

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Sep 24, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves rollup/plugins#583

Description

In SystemJS at the moment, every default export is creating a new variable. This is causing issues when by accident the variable name conflicts with the name of an imported namespace, which is fixed here.

@lukastaegert lukastaegert force-pushed the system-default-conflict branch from 8284bd3 to 4b7173f Sep 24, 2020
@rollup-bot
Copy link

@rollup-bot rollup-bot commented Sep 24, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#system-default-conflict

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13062

@codecov
Copy link

@codecov codecov bot commented Sep 24, 2020

Codecov Report

Merging #3796 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3796      +/-   ##
==========================================
- Coverage   97.03%   97.03%   -0.01%     
==========================================
  Files         185      185              
  Lines        6478     6477       -1     
  Branches     1877     1876       -1     
==========================================
- Hits         6286     6285       -1     
  Misses        101      101              
  Partials       91       91              
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a974a7...4b7173f. Read the comment docs.

@lukastaegert lukastaegert merged commit 72417f4 into master Sep 24, 2020
8 of 9 checks passed
8 of 9 checks passed
14 (Windows)
Details
12 (Windows)
Details
10 (Windows)
Details
codecov/project Codecov Report
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v14-latest Your tests passed on CircleCI!
Details
codecov/patch Codecov Report
Details
@lukastaegert lukastaegert deleted the system-default-conflict branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.