Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding individual exports of reexported external namespaces #3959

Merged
merged 1 commit into from Feb 12, 2021

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Feb 12, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3137

Description

This changes how external namespaces are reexported by moving the relevant code to the end and skipping local exports. In a previous PR, it was ensured that local exports are always defined as properties on the exports object at this point even if they have not yet been assigned a value.

@rollup-bot
Copy link
Collaborator

@rollup-bot rollup-bot commented Feb 12, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#override-namespace-export

or load it into the REPL:
https://rollupjs.org/repl/?circleci=14300

@codecov
Copy link

@codecov codecov bot commented Feb 12, 2021

Codecov Report

Merging #3959 (272ffd9) into master (0e3445b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3959   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         191      191           
  Lines        6703     6703           
  Branches     1960     1960           
=======================================
  Hits         6515     6515           
  Misses         99       99           
  Partials       89       89           
Impacted Files Coverage Δ
src/finalisers/shared/getExportBlock.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3445b...272ffd9. Read the comment docs.

@lukastaegert lukastaegert force-pushed the override-namespace-export branch from ce4c3d9 to 272ffd9 Feb 12, 2021
@lukastaegert lukastaegert merged commit 6f16528 into master Feb 12, 2021
9 checks passed
9 checks passed
@github-actions
14 (Windows)
Details
@github-actions
12 (Windows)
Details
@github-actions
10 (Windows)
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v14-latest Your tests passed on CircleCI!
Details
@codecov
codecov/patch 100.00% of diff hit (target 97.19%)
Details
@codecov
codecov/project 97.19% (+0.00%) compared to 0e3445b
Details
@lukastaegert lukastaegert deleted the override-namespace-export branch Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants