Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft breaks to guide to improve mobile experience #3976

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Feb 26, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This will add some soft-breaks into long inline code snippets to improve how the docs render on small screens.

@rollup-bot
Copy link
Collaborator

@rollup-bot rollup-bot commented Feb 26, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#guide-soft-breaks

or load it into the REPL:
https://rollupjs.org/repl/?circleci=14363

@codecov
Copy link

@codecov codecov bot commented Feb 26, 2021

Codecov Report

Merging #3976 (6142f3d) into master (a8a56fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3976   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         191      191           
  Lines        6706     6706           
  Branches     1961     1961           
=======================================
  Hits         6519     6519           
  Misses         99       99           
  Partials       88       88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a56fc...6142f3d. Read the comment docs.

@lukastaegert lukastaegert merged commit 9b8c94d into master Feb 26, 2021
9 checks passed
9 checks passed
@github-actions
14 (Windows)
Details
@github-actions
12 (Windows)
Details
@github-actions
10 (Windows)
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v14-latest Your tests passed on CircleCI!
Details
@codecov
codecov/patch Coverage not affected when comparing a8a56fc...6142f3d
Details
@codecov
codecov/project 97.21% (+0.00%) compared to a8a56fc
Details
@lukastaegert lukastaegert deleted the guide-soft-breaks branch Feb 26, 2021
This was referenced Mar 6, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants