Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export defineConfig defines the auxiliary function of the configuration #4127

Merged
merged 3 commits into from Jun 6, 2021

Conversation

@rxliuli
Copy link
Contributor

@rxliuli rxliuli commented Jun 6, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #4125

Description

@rxliuli
Copy link
Contributor Author

@rxliuli rxliuli commented Jun 6, 2021

@lukastaegert I added some documentation at the end

@github-actions
Copy link

@github-actions github-actions bot commented Jun 6, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rxliuli/rollup#feat_defineConfig

or load it into the REPL:
https://rollupjs.org/repl/?pr=4127

@rxliuli rxliuli changed the title Feat define config feat: Export defineConfig defines the auxiliary function of the configuration Jun 6, 2021
@codecov
Copy link

@codecov codecov bot commented Jun 6, 2021

Codecov Report

Merging #4127 (555cac3) into master (9f69fe3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4127   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         201      201           
  Lines        7077     7077           
  Branches     2071     2071           
=======================================
  Hits         6944     6944           
  Misses         64       64           
  Partials       69       69           
Impacted Files Coverage Δ
src/rollup/rollup.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f69fe3...555cac3. Read the comment docs.

@@ -200,6 +200,33 @@ export default commandLineArgs => {
}
```

Config Intellisense
Copy link
Member

@lukastaegert lukastaegert Jun 6, 2021

You should make this a #### sub-heading so that it looks right on the web site

Copy link
Member

@lukastaegert lukastaegert Jun 6, 2021

Otherwise looks great!

Copy link
Contributor Author

@rxliuli rxliuli Jun 6, 2021

added: 555cac3

Copy link
Member

@lukastaegert lukastaegert left a comment

Thanks 👍

@rxliuli
Copy link
Contributor Author

@rxliuli rxliuli commented Jun 6, 2021

I would like to ask, if yes, is it possible to support ts type configuration files? If I create a new PR to support this feature, will it be merged?

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jun 6, 2021

There is already a PR for this which got stalled: #3835
However, discussions were already pretty advanced, maybe we can move that one forward? The general idea would be to allow using plugins to transpile the config file, just the specifics were not finalized.

@lukastaegert lukastaegert merged commit d985955 into rollup:master Jun 6, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants