Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export rollup.defineConfig at runtime #4134

Merged
merged 4 commits into from Jun 8, 2021
Merged

fix: export rollup.defineConfig at runtime #4134

merged 4 commits into from Jun 8, 2021

Conversation

@mshrtsr
Copy link
Contributor

@mshrtsr mshrtsr commented Jun 8, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This PR fixes #4133.
I expose defineConfig from entrypoint(node-entry.ts, browser-entry.ts).
As a result, type definition and runtime correspond.

@github-actions
Copy link

@github-actions github-actions bot commented Jun 8, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install mshrtsr/rollup#fix/export-defineConfig

or load it into the REPL:
https://rollupjs.org/repl/?pr=4134

@mshrtsr mshrtsr changed the title fix: export rollup.defineConfig at Node.js runtime fix: export rollup.defineConfig at runtime Jun 8, 2021
@mshrtsr mshrtsr marked this pull request as ready for review Jun 8, 2021
Copy link
Member

@lukastaegert lukastaegert left a comment

Thanks, and ouch, this was really a mess. Reminds me why we usually test like mad...

@lukastaegert lukastaegert merged commit f46b80a into rollup:master Jun 8, 2021
8 checks passed
@mshrtsr mshrtsr deleted the fix/export-defineConfig branch Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants