Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TypeScript config and improve some types #4144

Merged
merged 4 commits into from Jun 21, 2021
Merged

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jun 17, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

To benefit from the new --configPlugin option, this will switch Rollup's own config to TypeScript. This immediately uncovered some inconsistencies in the typings that are resolved as well:

  • The renderChunk hook is allowed to return undefined
  • Plugins can also be falsy, in which case they are ignored
@github-actions
Copy link

@github-actions github-actions bot commented Jun 17, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#use-typescript-config

or load it into the REPL:
https://rollupjs.org/repl/?pr=4144

@lukastaegert lukastaegert force-pushed the use-typescript-config branch from 05a9c4f to 67697d0 Jun 17, 2021
@codecov
Copy link

@codecov codecov bot commented Jun 17, 2021

Codecov Report

Merging #4144 (37903aa) into master (bef5fe8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4144   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         201      201           
  Lines        7116     7116           
  Branches     2084     2084           
=======================================
  Hits         6994     6994           
  Misses         58       58           
  Partials       64       64           
Impacted Files Coverage Δ
src/utils/ensureArray.ts 100.00% <ø> (ø)
src/utils/renderChunk.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef5fe8...37903aa. Read the comment docs.

@lukastaegert lukastaegert merged commit 5b53d28 into master Jun 21, 2021
10 checks passed
@lukastaegert lukastaegert deleted the use-typescript-config branch Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant