Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates namespace objects when not tree-shaking #4175

Merged
merged 1 commit into from Jul 11, 2021

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jul 11, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #4174

Description

When tree shaking was turned off, sometimes namespace objects were not generated. This is fixed here.

@github-actions
Copy link

@github-actions github-actions bot commented Jul 11, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4174-no-treeshake-namespace

or load it into the REPL:
https://rollupjs.org/repl/?pr=4175

@codecov
Copy link

@codecov codecov bot commented Jul 11, 2021

Codecov Report

Merging #4175 (2c0f8e1) into master (7435d31) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4175   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         202      202           
  Lines        7219     7220    +1     
  Branches     2111     2111           
=======================================
+ Hits         7099     7100    +1     
  Misses         58       58           
  Partials       62       62           
Impacted Files Coverage Δ
src/Module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7435d31...2c0f8e1. Read the comment docs.

@lukastaegert lukastaegert merged commit 076b608 into master Jul 11, 2021
9 checks passed
@lukastaegert lukastaegert deleted the gh-4174-no-treeshake-namespace branch Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant