Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop recommending node-builtins #4190

Merged
merged 2 commits into from Jul 25, 2021
Merged

Stop recommending node-builtins #4190

merged 2 commits into from Jul 25, 2021

Conversation

@curran
Copy link
Contributor

@curran curran commented Jul 24, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Resolves #2881

Description

I recently went on a wild goose chase trying to figure out the best solution in the current Rollup ecosystem for polyfilling Node builtins. Long story short, this repository https://github.com/snowpackjs/rollup-plugin-polyfill-node looks to be, by far, the best alternative to the currently recommended repository, which has not been maintained for 2 years. I personally migrated to this package and it appears to work extremely well.

Related threads:

@curran curran changed the title Stop recommending node-builtins. Closes #2881 Stop recommending node-builtins Jul 24, 2021
@curran curran mentioned this pull request Jul 24, 2021
3 tasks
@curran
Copy link
Contributor Author

@curran curran commented Jul 24, 2021

Aha! Forgot to update the tests... Sorry. Will do.

@codecov
Copy link

@codecov codecov bot commented Jul 24, 2021

Codecov Report

Merging #4190 (cfcafad) into master (2a29db9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4190   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         202      202           
  Lines        7232     7232           
  Branches     2116     2116           
=======================================
  Hits         7112     7112           
  Misses         58       58           
  Partials       62       62           
Impacted Files Coverage Δ
cli/run/batchWarnings.ts 99.19% <ø> (ø)
src/finalisers/shared/warnOnBuiltins.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a29db9...cfcafad. Read the comment docs.

Niek
Niek approved these changes Jul 24, 2021
Copy link
Member

@lukastaegert lukastaegert left a comment

👍

@lukastaegert lukastaegert merged commit b1c4a17 into rollup:master Jul 25, 2021
9 checks passed
@curran
Copy link
Contributor Author

@curran curran commented Jul 26, 2021

Thanks @lukastaegert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants