Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect rendering of export declarations in SystemJS #4202

Merged
merged 1 commit into from Aug 8, 2021

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Aug 8, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4201

Description

Due to an ordering issue, export declarations with an initializer that was a simplified expression would lead to incorrect results.

@github-actions
Copy link

@github-actions github-actions bot commented Aug 8, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4201-fix-system-declarations

or load it into the REPL:
https://rollupjs.org/repl/?pr=4202

@codecov
Copy link

@codecov codecov bot commented Aug 8, 2021

Codecov Report

Merging #4202 (77033cc) into master (ffd5cad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4202   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         202      202           
  Lines        7253     7253           
  Branches     2126     2126           
=======================================
  Hits         7135     7135           
  Misses         58       58           
  Partials       60       60           
Impacted Files Coverage Δ
src/ast/nodes/VariableDeclaration.ts 98.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd5cad...77033cc. Read the comment docs.

@lukastaegert lukastaegert merged commit 039420b into master Aug 8, 2021
9 checks passed
@lukastaegert lukastaegert deleted the gh-4201-fix-system-declarations branch Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant