Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not abort watch mode on errors in watchChange #4427

Merged
merged 6 commits into from Mar 7, 2022

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Mar 4, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
#4424 (but does not resolve it completely)

Description

If there is an error in watchChange, this will make sure this error is displayed the same way as all other errors in watch mode and does not exit Rollup.

Also fixes direct installation of branches from Github via npm@7.

@github-actions
Copy link

@github-actions github-actions bot commented Mar 4, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4424_throw_watch_change

or load it into the REPL:
https://rollupjs.org/repl/?pr=4427

@codecov
Copy link

@codecov codecov bot commented Mar 4, 2022

Codecov Report

Merging #4427 (3f40562) into master (6881753) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4427   +/-   ##
=======================================
  Coverage   98.76%   98.77%           
=======================================
  Files         204      205    +1     
  Lines        7316     7324    +8     
  Branches     2079     2080    +1     
=======================================
+ Hits         7226     7234    +8     
  Misses         33       33           
  Partials       57       57           
Impacted Files Coverage Δ
src/utils/PluginDriver.ts 100.00% <ø> (ø)
src/watch/watch-proxy.ts 100.00% <ø> (ø)
cli/run/watch-cli.ts 89.70% <100.00%> (ø)
src/Graph.ts 100.00% <100.00%> (ø)
src/watch/WatchEmitter.ts 100.00% <100.00%> (ø)
src/watch/watch.ts 99.09% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6881753...3f40562. Read the comment docs.

@lukastaegert lukastaegert force-pushed the gh-4424_throw_watch_change branch 10 times, most recently from 46dc17f to 1eae026 Compare Mar 6, 2022
@lukastaegert lukastaegert force-pushed the gh-4424_throw_watch_change branch from 6fa85f3 to b2722c7 Compare Mar 6, 2022
@lukastaegert lukastaegert force-pushed the gh-4424_throw_watch_change branch from b2722c7 to 548332f Compare Mar 6, 2022
@lukastaegert lukastaegert merged commit cf75d71 into master Mar 7, 2022
12 checks passed
@lukastaegert lukastaegert deleted the gh-4424_throw_watch_change branch Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant