Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add object-known-globals #4429

merged 1 commit into from Mar 6, 2022


Copy link

@869288142 869288142 commented Mar 5, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


Copy link

@codecov codecov bot commented Mar 5, 2022

Codecov Report

Merging #4429 (86b26e9) into master (994c1ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4429   +/-   ##
  Coverage   98.76%   98.76%           
  Files         204      204           
  Lines        7309     7309           
  Branches     2077     2077           
  Hits         7219     7219           
  Misses         33       33           
  Partials       57       57           
Impacted Files Coverage Δ
src/ast/nodes/shared/knownGlobals.ts 92.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994c1ec...86b26e9. Read the comment docs.

Copy link

@lukastaegert lukastaegert left a comment

Looks good, thanks!

@lukastaegert lukastaegert merged commit 9c8894e into rollup:master Mar 6, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants