Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use void for options hook instead of undefined #4463

Merged
merged 3 commits into from Apr 15, 2022
Merged

Conversation

ycmjason
Copy link
Contributor

@ycmjason ycmjason commented Apr 13, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other: typing

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

currently we are required to return undefined in the options hook when using TS. this change would allow the options hook to have no return value.

currently we are required to return in the options hook. this change would allow the options hook to have no return value.
Copy link
Member

@lukastaegert lukastaegert left a comment

Good point, the intention is actually to allow you not to write a return. I also changed this for the other hooks.

@codecov
Copy link

@codecov codecov bot commented Apr 15, 2022

Codecov Report

Merging #4463 (b37bf91) into master (b8315e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4463   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         205      205           
  Lines        7326     7326           
  Branches     2079     2079           
=======================================
  Hits         7236     7236           
  Misses         33       33           
  Partials       57       57           
Impacted Files Coverage Δ
src/utils/options/normalizeInputOptions.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8315e0...b37bf91. Read the comment docs.

@lukastaegert lukastaegert merged commit ab21fdb into rollup:master Apr 15, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants