Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update deprecated option in tools.md #4467

Merged
merged 2 commits into from Apr 23, 2022
Merged

Conversation

kimjh96
Copy link
Contributor

@kimjh96 kimjh96 commented Apr 16, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

according to the documentation. I use the customResolveOptions.moduleDirectory option, but I get the following warning:

(!) Plugin node-resolve: node-resolve: The 'customResolveOptions.moduleDirectory' option has been deprecated. Use 'moduleDirectories', which must be an array.

I think this will also need to update the document.

Copy link
Member

@lukastaegert lukastaegert left a comment

👍

@lukastaegert lukastaegert enabled auto-merge (squash) Apr 23, 2022
@codecov
Copy link

@codecov codecov bot commented Apr 23, 2022

Codecov Report

Merging #4467 (ef8e199) into master (4b6627f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4467   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         205      205           
  Lines        7327     7327           
  Branches     2080     2080           
=======================================
  Hits         7236     7236           
  Misses         33       33           
  Partials       58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6627f...ef8e199. Read the comment docs.

@lukastaegert lukastaegert merged commit 52f1206 into rollup:master Apr 23, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants