Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with node.js v18, remove v17 #4478

Merged
merged 5 commits into from Apr 30, 2022
Merged

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Apr 25, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

@codecov codecov bot commented Apr 27, 2022

Codecov Report

Merging #4478 (452f4e1) into master (6518775) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4478   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         205      205           
  Lines        7327     7327           
  Branches     2080     2080           
=======================================
  Hits         7236     7236           
  Misses         33       33           
  Partials       58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6518775...452f4e1. Read the comment docs.

@dnalborczyk
Copy link
Contributor Author

@dnalborczyk dnalborczyk commented Apr 27, 2022

dang, related issue: nodejs/node#42638

@lukastaegert seems like there's multiple ways to solve this issue with node.js v18.

  • run the tests with disabled global fetch and wait for the source maps module to be fixed. somewhat unlikely given the module is pretty much unmaintained
  • use a fork
  • fork it ourselves

I applied #1 this as a temporary ci fix.

would it also be an option to use built-in source maps? https://nodejs.medium.com/source-maps-in-node-js-482872b56116
not sure to what extend source maps are being used currently in rollup. this is supported with v12+

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 28, 2022

The source-map package is solely used in tests to verify generated source maps. While this is important to test, it being a test dependency means we have a lot of freedom how to replace it / work around fixing it. Not sure if Node source map support would help as we really want to check if precise locations are mapped. If you have good ideas how to work around it, give them a go. Meanwhile, your solution looks fine to me as we really do not care about global fetch.

@lukastaegert lukastaegert enabled auto-merge (squash) Apr 28, 2022
@lukastaegert lukastaegert merged commit e3bfe69 into rollup:master Apr 30, 2022
12 checks passed
@dnalborczyk dnalborczyk deleted the test-node-v18 branch May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants