Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exports exception for loadConfigFile #4483

Merged
merged 2 commits into from Apr 30, 2022

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 30, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4460

Description

As we explicitly state that you can require loadConfigFile without extension in the docs, this will add an explicit exports route for this.

In preparation for the next major release where I would like to remove that hack again, loadConfigFile can now directly be imported as rollup/loadConfigFile as well.

@github-actions
Copy link

@github-actions github-actions bot commented Apr 30, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4460-rollup-package-exports

or load it into the REPL:
https://rollupjs.org/repl/?pr=4483

@codecov
Copy link

@codecov codecov bot commented Apr 30, 2022

Codecov Report

Merging #4483 (beb80ac) into master (edd971e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4483   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         205      205           
  Lines        7331     7331           
  Branches     2082     2082           
=======================================
  Hits         7240     7240           
  Misses         33       33           
  Partials       58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd971e...beb80ac. Read the comment docs.

@lukastaegert lukastaegert enabled auto-merge (squash) Apr 30, 2022
@lukastaegert lukastaegert disabled auto-merge Apr 30, 2022
@lukastaegert lukastaegert merged commit 51972b0 into master Apr 30, 2022
12 checks passed
@lukastaegert lukastaegert deleted the gh-4460-rollup-package-exports branch Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant