Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reassignment tracking #4486

Merged
merged 1 commit into from May 5, 2022
Merged

Fix reassignment tracking #4486

merged 1 commit into from May 5, 2022

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented May 4, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4468

Description

This one seemed quite the mystery bug. It seemed code was removed when you arranged things "just the right way". Turns out, the logic to prevent infinite recursions for assignment tracking was accidentally sharing an object with the same logic for property accesses, with the effect that an earlier property access could tell the system that an assignment had no effect even though it had.

@github-actions
Copy link

@github-actions github-actions bot commented May 4, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4468-unexpected-dce

or load it into the REPL:
https://rollupjs.org/repl/?pr=4486

@codecov
Copy link

@codecov codecov bot commented May 4, 2022

Codecov Report

Merging #4486 (e19adf3) into master (f44a3a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4486   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         205      205           
  Lines        7331     7331           
  Branches     2082     2082           
=======================================
  Hits         7240     7240           
  Misses         33       33           
  Partials       58       58           
Impacted Files Coverage Δ
src/ast/variables/LocalVariable.ts 93.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44a3a3...e19adf3. Read the comment docs.

@lukastaegert lukastaegert merged commit 6195638 into master May 5, 2022
12 checks passed
@lukastaegert lukastaegert deleted the gh-4468-unexpected-dce branch May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant