Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid maximum listeners exceeded warning #4502

Merged
merged 2 commits into from May 19, 2022
Merged

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented May 19, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This avoids the warning about exceeding maxListeners for the beforeExit event by using a single event listener that re-emits the event on a local emitter with unlimited listeners.

@github-actions
Copy link

@github-actions github-actions bot commented May 19, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#avoid-max-listeners-warning

or load it into the REPL:
https://rollupjs.org/repl/?pr=4502

@codecov
Copy link

@codecov codecov bot commented May 19, 2022

Codecov Report

Merging #4502 (7cf4765) into master (bf1ff32) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4502   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         207      207           
  Lines        7342     7346    +4     
  Branches     2081     2081           
=======================================
+ Hits         7250     7254    +4     
  Misses         33       33           
  Partials       59       59           
Impacted Files Coverage Δ
src/utils/hookActions.ts 95.23% <100.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf1ff32...7cf4765. Read the comment docs.

@lukastaegert lukastaegert merged commit 0537d93 into master May 19, 2022
12 checks passed
@lukastaegert lukastaegert deleted the avoid-max-listeners-warning branch May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant