Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid name conflicts for default exported classes #4756

merged 3 commits into from Dec 17, 2022


Copy link

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


Turns out the name conflict detection logic for classes was not working when a class was defined inside a default export declaration, which is fixed here. See also #4753 for more details.

Copy link

github-actions bot commented Dec 16, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4753-class-name-conflict

or load it into the REPL:

Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #4756 (60447ad) into master (ffab4cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4756   +/-   ##
  Coverage   99.04%   99.04%           
  Files         217      217           
  Lines        7711     7715    +4     
  Branches     2134     2135    +1     
+ Hits         7637     7641    +4     
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
src/ast/variables/ExportDefaultVariable.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit a27cf81 into master Dec 17, 2022
10 checks passed
@lukastaegert lukastaegert deleted the gh-4753-class-name-conflict branch December 17, 2022 05:26
Copy link

This PR has been released as part of rollup@3.7.5. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Overlapping class names
2 participants