Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RollupLog cause allow unknown #4757

merged 3 commits into from Dec 17, 2022


Copy link

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #4754


Copy link
Contributor Author

@lukastaegert due to it's my first contrib to rollup, please run the CI for me
I haven't checked anything and didn't installed npm deps locally yet, would like to test if this change without anything else already fulfills the CI's need and I don't have to put much more effort into it

@Shinigami92 Shinigami92 marked this pull request as ready for review December 16, 2022 14:31
src/rollup/types.d.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #4757 (249fc8a) into master (a27cf81) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4757   +/-   ##
  Coverage   99.04%   99.04%           
  Files         217      217           
  Lines        7715     7715           
  Branches     2135     2135           
  Hits         7641     7641           
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
cli/logging.ts 95.45% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 554ba9f into rollup:master Dec 17, 2022
10 checks passed
Copy link

This PR has been released as part of rollup@3.7.5. You can test it via npm install rollup.

Copy link
Contributor Author

@lukastaegert it works 👍
I released new version of my plugin that is compatible with Vite 2, 3 and 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

warn parameter is not compatible with Error anymore
3 participants