Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deduplicate reexports and renderedExports to simplify output #4759

merged 8 commits into from Dec 21, 2022


Copy link

@TrickyPi TrickyPi commented Dec 18, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

I think the existing test changes should cover it, but I'm not sure if the modifications of the 'system' test are correct, I need to learn about SystemJS.

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #4698


Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #4759 (259b3f0) into master (b86e706) will decrease coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #4759      +/-   ##
- Coverage   99.04%   99.03%   -0.02%     
  Files         217      217              
  Lines        7734     7749      +15     
  Branches     2143     2147       +4     
+ Hits         7660     7674      +14     
  Misses         24       24              
- Partials       50       51       +1     
Impacted Files Coverage Δ
src/Chunk.ts 99.82% <94.73%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member Author

TrickyPi commented Dec 19, 2022

I think the current changes are generating wrong System output, and the changes only have trivial effect on the amd and cjs output. Maybe we should move the changes to the es.ts or change system.ts?

Copy link

Yes, then do it just for es.

@lukastaegert lukastaegert merged commit 6b3f556 into rollup:master Dec 21, 2022
8 of 10 checks passed
@TrickyPi TrickyPi deleted the feat/dedup branch December 22, 2022 02:10
Copy link

This PR has been released as part of rollup@3.8.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

preserveModules caused some unnecessary import and export.
3 participants