Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of namespace reexports when preserving modules #4766

merged 2 commits into from Dec 23, 2022


Copy link

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


Apparently, one assumption from me was wrong about what does or does not occur in a chunks dependencies.

Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4765-namespace-reexport

or load it into the REPL:

Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #4766 (22283f4) into master (1243370) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4766   +/-   ##
  Coverage   99.03%   99.03%           
  Files         217      217           
  Lines        7762     7764    +2     
  Branches     2148     2149    +1     
+ Hits         7687     7689    +2     
  Misses         24       24           
  Partials       51       51           
Impacted Files Coverage Δ
src/Chunk.ts 99.82% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 571f3a8 into master Dec 23, 2022
7 of 8 checks passed
@lukastaegert lukastaegert deleted the gh-4765-namespace-reexport branch December 23, 2022 05:31
Copy link

This PR has been released as part of rollup@3.8.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Build fails in rollup@3.8.0 when using resolve() and preserveModules
2 participants