Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove array grouping (web compat issue) #4779

merged 2 commits into from Jan 2, 2023


Copy link

@dnalborczyk dnalborczyk commented Dec 30, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

removes array grouping prototype methods as they hit another web compat issue. I think the latest thought is not to rename again but to use static functions. 馃槥



Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #4779 (cceeeeb) into master (bceb353) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4779   +/-   ##
  Coverage   99.03%   99.03%           
  Files         217      217           
  Lines        7773     7773           
  Branches     2159     2159           
  Hits         7698     7698           
  Misses         24       24           
  Partials       51       51           
Impacted Files Coverage 螖
src/ast/nodes/shared/ArrayPrototype.ts 100.00% <酶> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert enabled auto-merge (squash) January 2, 2023 06:53
@lukastaegert lukastaegert merged commit 08b61f5 into rollup:master Jan 2, 2023
9 of 10 checks passed
@dnalborczyk dnalborczyk deleted the remove-array-group branch January 2, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants