Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Set and builtin-modules package #4781

merged 4 commits into from Jan 2, 2023


Copy link

@dnalborczyk dnalborczyk commented Dec 30, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


the node-builtin list is quite outdated. refactored the code to use an external module. also adds additional PR pending modules.


Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #4781 (a5a646b) into master (f00b251) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4781   +/-   ##
  Coverage   99.03%   99.03%           
  Files         217      217           
  Lines        7774     7774           
  Branches     2159     2159           
  Hits         7699     7699           
  Misses         24       24           
  Partials       51       51           
Impacted Files Coverage Δ
src/finalisers/shared/warnOnBuiltins.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert enabled auto-merge (squash) January 2, 2023 09:17
@lukastaegert lukastaegert merged commit 023ed0f into rollup:master Jan 2, 2023
10 checks passed
@dnalborczyk dnalborczyk deleted the node-builtins branch January 2, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants