Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix cross-chunk-reexport warning #4829

merged 2 commits into from Feb 1, 2023


Copy link

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


The root cause of #4804 was that namespace exports do not have an export name. This fixes the warning by using "*" as the export name. It also shows the warning in more situations as it was omitted if one export was a namespace and we were preserving modules.

Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit e440b4d
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

github-actions bot commented Jan 29, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#cross-chunk-reexports

or load it into the REPL:

Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #4829 (c1fdf07) into master (48553ca) will decrease coverage by 0.02%.
The diff coverage is 90.90%.

Current head c1fdf07 differs from pull request most recent head e440b4d. Consider uploading reports for the commit e440b4d to get more accurate results

@@            Coverage Diff             @@
##           master    #4829      +/-   ##
- Coverage   99.00%   98.99%   -0.02%     
  Files         219      219              
  Lines        7834     7837       +3     
  Branches     2168     2170       +2     
+ Hits         7756     7758       +2     
  Misses         26       26              
- Partials       52       53       +1     
Impacted Files Coverage Δ
src/utils/renderHelpers.ts 100.00% <ø> (ø)
src/Chunk.ts 99.65% <83.33%> (-0.18%) ⬇️
src/ast/nodes/ClassDeclaration.ts 100.00% <100.00%> (ø)
src/ast/nodes/Identifier.ts 100.00% <100.00%> (ø)
src/ast/variables/Variable.ts 100.00% <100.00%> (ø)
src/utils/error.ts 98.96% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit ef25721 into master Feb 1, 2023
13 of 15 checks passed
@lukastaegert lukastaegert deleted the cross-chunk-reexports branch February 1, 2023 08:28
Copy link

This PR has been released as part of rollup@3.12.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants