Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning not to add assets directly to the bundle #4831

merged 2 commits into from Feb 1, 2023


Copy link

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit 18bf9a5
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

github-actions bot commented Jan 31, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#warning-for-this-emitfile

or load it into the REPL:

Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #4831 (18bf9a5) into master (669f597) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4831   +/-   ##
  Coverage   98.99%   98.99%           
  Files         219      219           
  Lines        7839     7839           
  Branches     2171     2171           
  Hits         7760     7760           
  Misses         26       26           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 0c5aa76 into master Feb 1, 2023
15 checks passed
@lukastaegert lukastaegert deleted the warning-for-this-emitfile branch February 1, 2023 08:50
Copy link

This PR has been released as part of rollup@3.12.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants