Rework #34
Merged
Rework #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AMHOL @cflipse @flash-gordon @timriley ding dong, please check this out. I'd love to get it done and add a couple features (associations mostly and a built-in json adapter specialization) on top of this rework. |
|
Looks okay so far |
flash-gordon
approved these changes
Mar 30, 2018
lib/rom/http/relation.rb
Outdated
|
|
||
| require 'rom/http/attribute' | ||
| require 'rom/http/schema/dsl' | ||
| require 'rom/http/schema/dsl' |
lib/rom/http/relation.rb
Outdated
| else | ||
| :id | ||
| end | ||
| schema.primary_key[0].name |
There was a problem hiding this comment.
I think we can have a missing method here, mb it's a good idea to raise a meaningful exception
added 22 commits
March 31, 2018 12:54
* Add HTTP::Schema and HTTP::Attribute
* Add custom HTTP::MapperCompiler
* Remove manual transformations in favor of auto-mapping feature from core
* Simplify some specs
* Remove applying transformations in insert/update - this type of
functionality is not supported by core and it's actually something we
intentionally do not want to have. Input that doesn't match
canonical data structures can be handled by changesets with their
mappings
* Rely on options exclusively in dataset, remove config idea completely * Remove Dataset#name, use #base_path * Refactor dataset spec using simpler syntax and simpler examples * Change Gateway#dataset to set up a dataset using options based on its config
It's better to have duplication in specs than to make it more complex with more blocks and meta-programming
* Use constants for default values * Use HTTP::Types::Path instead of utility method * Simplify option declarations
|
I merged this in, feel free to provide further feedback here though, and I'll address it in new PRs or directly in master. |
|
@solnic can this branch be deleted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add HTTP::SchemaandHTTP::AttributeHTTP::MapperCompilerDatasetso that it only uses its optionsDataset#nameas it felt like additional complexityDataset::ClassInterface(we're in beta phase, no need to go through deprecation cycles)Dataset#{get?,post?,put?,delete?}HTTP::Relation#wrapas this is now a core method and it does something else