New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default dataset available within the dataset configuration block #515

Open
solnic opened this Issue Dec 30, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@solnic
Copy link
Member

solnic commented Dec 30, 2018

A common scenario is when you want to adjust the default dataset rather than setting it up from scratch, that's why it will be convenient when the default dataset is available within the Relation.dataset configuration block.

Probably the best way to do this is to tweak Gateway#dataset so that it can also accept a schema because we have it available already when dataset is retrieved from the gateway. This way the gateway will be responsible for returning the default dataset in rom-sql too (right now we use a configuration event for this). A huge benefit of this approach is that we won't have to introduce any new interface and/or change the behavior of the dataset block.

Resources

@solnic solnic added the feature label Dec 30, 2018

@solnic solnic added this to the v5.0.0 milestone Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment