ht1 done#4
Closed
musiclover174 wants to merge 4 commits into
Closed
Conversation
musiclover174
commented
Feb 24, 2018
musiclover174
commented
- Компонент dayPicker'а взял целиком, заимпортил, как инстанс-компонент и просто использовал на странице.
- разделил по папка article (article + articleList) и comments (comment + commentsList)
- propTypes для комментсов добавил
romabelka
reviewed
Feb 25, 2018
| @@ -0,0 +1,77 @@ | |||
| import React from 'react'; | |||
| import Helmet from 'react-helmet'; | |||
Owner
There was a problem hiding this comment.
Зачем тебе react-helmet, никогда не копируй необдуманно примеры из документаций
| @@ -0,0 +1,13 @@ | |||
| import React from 'react' | |||
|
|
|||
| export default (OriginalToggle) => class DecoratedToggle extends React.Component { | |||
Owner
There was a problem hiding this comment.
DecoratedComponent я называл чтоб легче понять было. Лучше выбирай более значущее название
jekahm
added a commit
to jekahm/basic-react-1902
that referenced
this pull request
Mar 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.