rlog: add Printf/Println and rename SetNewLogWriter to match standard log pkg. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes but it is good to have some defaults instead of breaking 1000+ line which has those, this way we don't create so many log PR's and replace log with rlog with only change in import function. less PR's, less code change, etc. |
jbrendel
reviewed
Dec 1, 2016
| @@ -385,6 +385,17 @@ func Infof(format string, a ...interface{}) { | |||
| basicLog(levelInfo, notATrace, format, "", a...) | |||
| } | |||
|
|
|||
| // Println prints a message if RLOG_LEVEL is set to INFO or lower. | |||
There was a problem hiding this comment.
Could we have a comment in here then that this is mostly for compatibility, but that it isn't really encouraged? Also, why not set it to DEBUG? That won't break anything and it'll make people think about the levels they want if they really want those messages.
There was a problem hiding this comment.
yep will add a comment there.
didn't make it debug because that disables most of the log and we need some fine tuning, till then info is good enough output to have there..
pritesh
force-pushed
the
improvement/support-std-log-features
branch
from
5c57eee
to
41a3674
Compare
jbrendel
approved these changes
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rlog: add Printf/Println and rename SetNewLogWriter to match standard log pkg.