New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on High Sierra GM Build #18

Closed
iamsankalp opened this Issue Sep 22, 2017 · 15 comments

Comments

Projects
None yet
7 participants
@iamsankalp

iamsankalp commented Sep 22, 2017

Hi, Roman! Thanks for the awesome plugin.

As soon as I try to run the plugin to arrange artboards - Sketch crashes. I had installed it via Sketch Runner.

Is this a known issue?

@romannurik

This comment has been minimized.

Show comment
Hide comment
@romannurik

romannurik Sep 30, 2017

Owner

I don't have High Sierra yet so unfortunately can't troubleshoot :-/ seeing the log from Console.app would be useful!

Owner

romannurik commented Sep 30, 2017

I don't have High Sierra yet so unfortunately can't troubleshoot :-/ seeing the log from Console.app would be useful!

@olafchou

This comment has been minimized.

Show comment
Hide comment
@olafchou

olafchou Sep 30, 2017

what should i do ?? could tell me which step should i operate ?

olafchou commented Sep 30, 2017

what should i do ?? could tell me which step should i operate ?

@iamsankalp

This comment has been minimized.

Show comment
Hide comment
@iamsankalp

iamsankalp Sep 30, 2017

Hi, Roman!

Uploading an archive with two files.

  1. sketch_console - this is from the console.app. I started console app, then started sketch and run the plugin once. After which it crashed. Then searched for 'Sketch' in console and put up this log in text file.

  2. sketch_quit_details - this if from 'Sketch quit unexpectedly' native dialog details.

Hope this is of help.

Sankalp

sketch_log.zip

iamsankalp commented Sep 30, 2017

Hi, Roman!

Uploading an archive with two files.

  1. sketch_console - this is from the console.app. I started console app, then started sketch and run the plugin once. After which it crashed. Then searched for 'Sketch' in console and put up this log in text file.

  2. sketch_quit_details - this if from 'Sketch quit unexpectedly' native dialog details.

Hope this is of help.

Sankalp

sketch_log.zip

@olafchou

This comment has been minimized.

Show comment
Hide comment
@olafchou

olafchou commented Oct 1, 2017

@romannurik

This comment has been minimized.

Show comment
Hide comment
@romannurik

romannurik Oct 1, 2017

Owner

Thanks all! @iamsankalp in your log, it looks like the plugin command is exposing some sort of bug in Sketch, but it's not clear what code in the plugin is triggering this. I'll have to try to get my hands on High Sierra and troubleshoot. Don't know of any workarounds in the meantime, sadly :-/

FWIW, this is the closest thing to a culprit I've found:

error	00:20:48.831082 +0530	Sketch	Unable to simultaneously satisfy constraints:
(
    "<NSAutoresizingMaskLayoutConstraint:0x608000686db0 h=--& v=--& MSGradientView:0x604000580dd0.width == 0   (active)>",
    "<NSAutoresizingMaskLayoutConstraint:0x60800009bd50 h=-&- v=&-- H:[NSTextField:0x7ff4c4775460]-(35)-|   (active, names: '|':MSGradientView:0x604000580dd0 )>",
    "<NSAutoresizingMaskLayoutConstraint:0x60800048ad70 h=-&- v=&-- NSTextField:0x7ff4c4775460.minX == 7   (active, names: '|':MSGradientView:0x604000580dd0 )>"
)

Will attempt to recover by breaking constraint 
<NSAutoresizingMaskLayoutConstraint:0x60800009bd50 h=-&- v=&-- H:[NSTextField:0x7ff4c4775460]-(35)-|   (active, names: '|':MSGradientView:0x604000580dd0 )>

Set the NSUserDefault NSConstraintBasedLayoutVisualizeMutuallyExclusiveConstraints to YES to have -[NSWindow visualizeConstraints:] automatically called when this happens.  And/or, set a symbolic breakpoint on LAYOUT_CONSTRAINTS_NOT_SATISFIABLE to catch this in the debugger.
default	00:20:48.955666 +0530	systemsoundserverd	686: -> Incoming Request : actionID 4096, inClientPID 4046(Sketch), inBehavior 1, customVibeDataProvided 0, loop 0, loopPeriod 0.000000, inFlags 0, inClientCompletionToken 2
default	00:20:51.101544 +0530	Sketch	LSExceptions shared instance invalidated for timeout.
default	00:20:51.655451 +0530	Sketch	0x7ff4c4457a60 - PerformanceMonitor::measurePostBackgroundingMemoryUsage: Process was using 220209152 bytes of memory after becoming non visible.
default	00:20:52.944325 +0530	kernel	AGC:: [Sketch pid 4046 mux-aware] exiting, non-mux-aware app count 0, runtime: 0:00:11.535
Owner

romannurik commented Oct 1, 2017

Thanks all! @iamsankalp in your log, it looks like the plugin command is exposing some sort of bug in Sketch, but it's not clear what code in the plugin is triggering this. I'll have to try to get my hands on High Sierra and troubleshoot. Don't know of any workarounds in the meantime, sadly :-/

FWIW, this is the closest thing to a culprit I've found:

error	00:20:48.831082 +0530	Sketch	Unable to simultaneously satisfy constraints:
(
    "<NSAutoresizingMaskLayoutConstraint:0x608000686db0 h=--& v=--& MSGradientView:0x604000580dd0.width == 0   (active)>",
    "<NSAutoresizingMaskLayoutConstraint:0x60800009bd50 h=-&- v=&-- H:[NSTextField:0x7ff4c4775460]-(35)-|   (active, names: '|':MSGradientView:0x604000580dd0 )>",
    "<NSAutoresizingMaskLayoutConstraint:0x60800048ad70 h=-&- v=&-- NSTextField:0x7ff4c4775460.minX == 7   (active, names: '|':MSGradientView:0x604000580dd0 )>"
)

Will attempt to recover by breaking constraint 
<NSAutoresizingMaskLayoutConstraint:0x60800009bd50 h=-&- v=&-- H:[NSTextField:0x7ff4c4775460]-(35)-|   (active, names: '|':MSGradientView:0x604000580dd0 )>

Set the NSUserDefault NSConstraintBasedLayoutVisualizeMutuallyExclusiveConstraints to YES to have -[NSWindow visualizeConstraints:] automatically called when this happens.  And/or, set a symbolic breakpoint on LAYOUT_CONSTRAINTS_NOT_SATISFIABLE to catch this in the debugger.
default	00:20:48.955666 +0530	systemsoundserverd	686: -> Incoming Request : actionID 4096, inClientPID 4046(Sketch), inBehavior 1, customVibeDataProvided 0, loop 0, loopPeriod 0.000000, inFlags 0, inClientCompletionToken 2
default	00:20:51.101544 +0530	Sketch	LSExceptions shared instance invalidated for timeout.
default	00:20:51.655451 +0530	Sketch	0x7ff4c4457a60 - PerformanceMonitor::measurePostBackgroundingMemoryUsage: Process was using 220209152 bytes of memory after becoming non visible.
default	00:20:52.944325 +0530	kernel	AGC:: [Sketch pid 4046 mux-aware] exiting, non-mux-aware app count 0, runtime: 0:00:11.535
@ugaldew

This comment has been minimized.

Show comment
Hide comment
@ugaldew

ugaldew Oct 3, 2017

I wil be looking forward, your plug in is incredibly helpful ... Thank you Roman

ugaldew commented Oct 3, 2017

I wil be looking forward, your plug in is incredibly helpful ... Thank you Roman

@patrickplaggenborg

This comment has been minimized.

Show comment
Hide comment
@patrickplaggenborg

patrickplaggenborg Oct 10, 2017

Broken here as well.

Just updated both to High Sierra and Sketch 47. Thought it was Sketch, but is probably related to this issue report about High Sierra.

Submitted a crash report to Sketch and to Apple, if that helps. Hope it can be fixed in the plugin itself.

Glad you're on it, thank you!

patrickplaggenborg commented Oct 10, 2017

Broken here as well.

Just updated both to High Sierra and Sketch 47. Thought it was Sketch, but is probably related to this issue report about High Sierra.

Submitted a crash report to Sketch and to Apple, if that helps. Hope it can be fixed in the plugin itself.

Glad you're on it, thank you!

@romannurik

This comment has been minimized.

Show comment
Hide comment
@romannurik

romannurik Oct 18, 2017

Owner

Hey folks, can someone try this build?

ArtboardTricks.zip

Owner

romannurik commented Oct 18, 2017

Hey folks, can someone try this build?

ArtboardTricks.zip

@herkulano

This comment has been minimized.

Show comment
Hide comment
@herkulano

herkulano commented Oct 19, 2017

@romannurik works! 💯

@ugaldew

This comment has been minimized.

Show comment
Hide comment
@ugaldew

ugaldew Oct 19, 2017

It ... WORKS!!! Thank you Roman ! this plug in is pure genius !

ugaldew commented Oct 19, 2017

It ... WORKS!!! Thank you Roman ! this plug in is pure genius !

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Oct 19, 2017

Can confirm it works for me too. High Sierra and Sketch v. 47.1 (45422), latest as of writing this. Thank you!

jasmussen commented Oct 19, 2017

Can confirm it works for me too. High Sierra and Sketch v. 47.1 (45422), latest as of writing this. Thank you!

@iamsankalp

This comment has been minimized.

Show comment
Hide comment
@iamsankalp

iamsankalp Oct 19, 2017

Works perfect. I have tested it on High Sierra Beta 13.1 with Sketch 47.1.

Thanks, @romannurik! Really appreciate your time.

iamsankalp commented Oct 19, 2017

Works perfect. I have tested it on High Sierra Beta 13.1 with Sketch 47.1.

Thanks, @romannurik! Really appreciate your time.

@patrickplaggenborg

This comment has been minimized.

Show comment
Hide comment
@patrickplaggenborg

patrickplaggenborg Oct 19, 2017

Replaced my current 1.0.5 with this build and works for me as well!

Thanks @romannurik!

(High Sierra 10.13 (17A405) and Sketch 47.1 (45422).

patrickplaggenborg commented Oct 19, 2017

Replaced my current 1.0.5 with this build and works for me as well!

Thanks @romannurik!

(High Sierra 10.13 (17A405) and Sketch 47.1 (45422).

@romannurik

This comment has been minimized.

Show comment
Hide comment
@romannurik

romannurik Oct 19, 2017

Owner
Owner

romannurik commented Oct 19, 2017

@romannurik

This comment has been minimized.

Show comment
Hide comment
@romannurik

romannurik Oct 19, 2017

Owner

Fixed in 1.0.6

Owner

romannurik commented Oct 19, 2017

Fixed in 1.0.6

@romannurik romannurik closed this Oct 19, 2017

@romannurik romannurik referenced this issue Jan 19, 2018

Closed

Crashing #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment