Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize images by Imgbot #610

Merged
merged 9 commits into from Jul 16, 2019

Conversation

@phanirithvij
Copy link
Contributor

commented Jul 14, 2019

What is Imgbot?

ImgBotApp and others added some commits Jun 30, 2019

[ImgBot] Optimize images
*Total -- 131,076.17kb -> 96,775.90kb (26.17%)

/main/src/main/res/drawable-xxhdpi/scrubber_track.9.png -- 1.07kb -> 0.35kb (67.28%)
/art/screenshots/tablet-10/activate.png -- 5,859.02kb -> 2,864.94kb (51.1%)
/art/screenshots/tablet-7/activate.png -- 2,650.46kb -> 1,393.15kb (47.44%)
/main/src/main/res/drawable-xxhdpi/ic_notif_next_artwork.png -- 1.81kb -> 1.02kb (43.83%)
/art/screenshots/tablet-10/effects.png -- 2,794.81kb -> 1,580.44kb (43.45%)
/source-gallery/src/main/res/drawable-xxhdpi/gallery_chosen_photo_selected.png -- 1.53kb -> 0.87kb (43.19%)
/art/screenshots/tablet-10/home.png -- 5,398.22kb -> 3,181.91kb (41.06%)
/art/screenshots/tablet-7/effects.png -- 1,264.96kb -> 752.30kb (40.53%)
/main/src/main/res/drawable-xxhdpi/tutorial_icon_on_overlay_base.png -- 3.80kb -> 2.27kb (40.39%)
/art/screenshots/phone/effects.png -- 1,137.40kb -> 680.44kb (40.18%)
/art/screenshots/tablet-7/home.png -- 2,890.43kb -> 1,774.81kb (38.6%)
/art/screenshots/tablet-7/gallery.png -- 3,776.50kb -> 2,339.26kb (38.06%)
/art/screenshots/phone/gallery.png -- 4,019.24kb -> 2,535.59kb (36.91%)
/art/screenshots/phone/home.png -- 1,937.37kb -> 1,227.16kb (36.66%)
/art/screenshots/tablet-10/gallery.png -- 8,866.49kb -> 5,712.66kb (35.57%)
/web/frontend/images/fakeui/systemui.png -- 5.30kb -> 3.47kb (34.52%)
/art/screenshots/phone/activate.png -- 5,383.71kb -> 3,565.44kb (33.77%)
/main/src/main/res/drawable-xxhdpi/logo_subtitle.png -- 2.88kb -> 1.92kb (33.29%)
/main/src/main/res/drawable-xxhdpi/scrubber_control_pressed.png -- 2.43kb -> 1.63kb (32.88%)
/art/screenshots/tablet-7/main.png -- 6,525.40kb -> 4,432.06kb (32.08%)
/legacy-standalone/src/main/res/drawable-nodpi/legacy_ic_source_selected.png -- 5.64kb -> 3.85kb (31.66%)
/art/screenshots/tablet-10/sources.png -- 4,969.14kb -> 3,401.52kb (31.55%)
/art/screenshots/phone/main.png -- 5,666.38kb -> 3,889.16kb (31.36%)
/art/screenshots/tablet-10/main.png -- 12,949.96kb -> 9,017.27kb (30.37%)
/main/src/main/res/drawable-xxhdpi/scrubber_control_disabled.png -- 1.38kb -> 0.97kb (29.72%)
/web/frontend/images/onplay.png -- 9.30kb -> 6.54kb (29.68%)
/art/screenshots/tablet-7/sources.png -- 2,277.51kb -> 1,622.61kb (28.76%)
/art/screenshots/phone/sources.png -- 2,844.97kb -> 2,066.25kb (27.37%)
/main/src/main/res/drawable-xxhdpi/about_android_experiment.png -- 9.25kb -> 6.89kb (25.5%)
/art/screenshots/tablet-10/auto_advance.png -- 3,528.63kb -> 2,638.80kb (25.22%)
/main/src/main/res/drawable-xxhdpi/scrubber_control_focused.png -- 1.74kb -> 1.31kb (24.59%)
/art/screenshots/tablet-7/auto_advance.png -- 928.63kb -> 720.85kb (22.37%)
/main/src/main/res/drawable-xxhdpi/ic_skip.png -- 2.10kb -> 1.64kb (21.95%)
/main/src/main/res/drawable-xxhdpi/scrubber_control_normal.png -- 2.24kb -> 1.76kb (21.52%)
/main/src/main/res/drawable-xxhdpi/ic_overflow.png -- 0.98kb -> 0.78kb (20.6%)
/art/screenshots/phone/auto_advance.png -- 800.22kb -> 642.38kb (19.72%)
/android-client-common/src/main/res/drawable-xxhdpi/ic_stat_muzei.png -- 1.80kb -> 1.48kb (17.76%)
/main/src/main/res/drawable-xxhdpi/scrubber_track_blur_amount.9.png -- 2.84kb -> 2.34kb (17.63%)
/example-unsplash/src/main/res/mipmap-xxxhdpi/source_ic_launcher_foreground.png -- 3.87kb -> 3.24kb (16.14%)
/example-unsplash/src/main/res/mipmap-xxhdpi/source_ic_launcher_foreground.png -- 2.67kb -> 2.26kb (15.32%)
/wearable/src/main/res/drawable-nodpi/preview.png -- 213.26kb -> 181.52kb (14.88%)
/example-watchface/src/main/res/drawable-hdpi/preview.png -- 282.19kb -> 245.78kb (12.9%)
/main/src/main/res/drawable-nodpi/preview.png -- 289.32kb -> 252.44kb (12.75%)
/art/screenshots/gallery_photos/MVIMG_20180220_142109-EFFECTS.jpg -- 5,990.95kb -> 5,233.45kb (12.64%)
/web/frontend/images/social-thumb.jpg -- 251.53kb -> 221.58kb (11.91%)
/wearable/src/main/res/drawable-nodpi/preview_circular.png -- 232.43kb -> 205.59kb (11.55%)
/art/screenshots/gallery_photos/IMG_20140821_144847.jpg -- 931.88kb -> 826.33kb (11.33%)
/art/screenshots/gallery_photos/IMG_20180804_162928-EFFECTS.jpg -- 3,370.61kb -> 3,003.48kb (10.89%)
/example-unsplash/src/main/res/mipmap-xhdpi/source_ic_launcher_foreground.png -- 1.58kb -> 1.42kb (9.86%)
/main/src/main/res/drawable-xxhdpi/ic_notif_user_command.png -- 0.88kb -> 0.79kb (9.69%)
/art/screenshots/gallery_photos/IMG_20180428_125855-EFFECTS.jpg -- 922.39kb -> 834.49kb (9.53%)
/art/screenshots/gallery_photos/IMG_20180809_170639-EFFECTS.jpg -- 3,890.19kb -> 3,526.93kb (9.34%)
/art/screenshots/gallery_photos/IMG_20180805_114157-EFFECTS.jpg -- 3,657.19kb -> 3,319.74kb (9.23%)
/art/screenshots/gallery_photos/IMG_20180803_125143-EFFECTS.jpg -- 1,932.21kb -> 1,762.38kb (8.79%)
/art/screenshots/gallery_photos/IMG_20180805_110436-EFFECTS.jpg -- 2,784.16kb -> 2,543.22kb (8.65%)
/art/screenshots/gallery_photos/PANO_20150129_125819.jpg -- 2,829.81kb -> 2,585.82kb (8.62%)
/art/screenshots/gallery_photos/PANO_20140815_104718.jpg -- 3,566.59kb -> 3,269.27kb (8.34%)
/art/screenshots/gallery_photos/IMG_20180729_170101-EFFECTS.jpg -- 3,402.51kb -> 3,119.23kb (8.33%)
/art/screenshots/gallery_photos/PANO_20150128_214236.jpg -- 1,013.81kb -> 931.96kb (8.07%)
/art/screenshots/gallery_photos/PANO_20141021_130736.jpg -- 2,708.92kb -> 2,503.27kb (7.59%)
/example-unsplash/src/main/res/mipmap-hdpi/source_ic_launcher_foreground.png -- 1.11kb -> 1.03kb (7.37%)
/main/src/main/res/drawable-xxhdpi/scrubber_track_grey_amount.9.png -- 9.26kb -> 8.59kb (7.2%)
/main/src/main/res/drawable-xxhdpi/tutorial_icon.png -- 20.81kb -> 19.40kb (6.79%)
/android-client-common/src/main/res/drawable-xhdpi/ic_stat_muzei.png -- 1.11kb -> 1.05kb (5.78%)
/wearable/src/main/assets/starrynight.jpg -- 52.46kb -> 49.45kb (5.74%)
/main/src/main/res/drawable-xxhdpi/scrubber_track_dim_amount.9.png -- 0.93kb -> 0.88kb (5.34%)
/art/screenshots/gallery_photos/20140313_092747_852.jpg -- 1,226.26kb -> 1,171.13kb (4.5%)
/art/ic_launcher-web.png -- 39.18kb -> 37.53kb (4.2%)
/android-client-common/src/main/res/mipmap-xhdpi/ic_launcher.png -- 7.70kb -> 7.45kb (3.32%)
/android-client-common/src/main/res/mipmap-xxhdpi/ic_launcher.png -- 12.20kb -> 11.86kb (2.82%)
/main/src/main/assets/starrynight.jpg -- 1,097.48kb -> 1,066.99kb (2.78%)
/art/screenshots/gallery_photos/20140313_095649_230.jpg -- 741.00kb -> 721.46kb (2.64%)
/android-client-common/src/main/res/mipmap-xxxhdpi/ic_launcher.png -- 16.62kb -> 16.18kb (2.63%)
/web/frontend/images/fakeui/device-tilted-fallback.jpg -- 25.05kb -> 24.51kb (2.13%)
/art/screenshots/gallery_photos/2010-04-04 14.08.24.jpg -- 708.58kb -> 693.91kb (2.07%)
/web/frontend/images/fakeui/device-flat-fallback.jpg -- 90.13kb -> 88.27kb (2.06%)
/art/screenshots/gallery_photos/IMG_3471.JPG -- 535.70kb -> 525.29kb (1.94%)
/android-client-common/src/main/res/mipmap-hdpi/ic_launcher.png -- 5.64kb -> 5.56kb (1.54%)
/main/src/main/res/drawable-nodpi/thumb.png -- 16.28kb -> 16.06kb (1.33%)
/art/screenshots/gallery_photos/IMG_20160127_174000.jpg -- 1,046.38kb -> 1,039.29kb (0.68%)
/web/frontend/images/fakeui/home.png -- 21.74kb -> 21.71kb (0.11%)
/art/screenshots/gallery_photos/PANO_20150131_202239.jpg -- 596.09kb -> 596.06kb (0.01%)
Merge pull request #1 from phanirithvij/imgbot
[ImgBot] Optimize images
@ianhanniballake
Copy link
Collaborator

left a comment

This touches way more files that it needs to (nothing under art/ should be touched) and introduces subtle changes in many of the images.

Please revert the changes on all files except the following (which seem fine):

  • main/src/main/assets/starrynight.jpg
  • wearable/src/main/assets/starrynight.jpg

phanirithvij added some commits Jul 15, 2019

Merge pull request #2 from phanirithvij/revert-1-imgbot
Revert "[ImgBot] Optimize images"
@phanirithvij

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

I've reverted everything and added just those files. @ianhanniballake

@ianhanniballake ianhanniballake merged commit 30e9ddb into romannurik:master Jul 16, 2019

@ianhanniballake

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.