deprecate unused config option timestamp
#1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
reviewed
Jun 9, 2024
|
@antonilol please squash the commits and update PR's title. |
original commits: deprecate unused config options `daemon_dir` and `timestamp` fix tests show all deprecation messages before exiting also possibly show log_filters message before exiting revert `daemon_dir` config option deprecation
antonilol
force-pushed
the
unused-config-options
branch
from
d28c364
to
8787ac9
Compare
antonilol
changed the title
daemon_dir and timestamptimestamp
|
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1044
Feel free to edit any of the messages by directly committing (but review is still fine)
Is
std::process::exit(1);desirable? This forces users to remove the flag with a nice message, in future releases they will get an error from the arg parser. When not exiting people might (and will) miss it, how many people look at the logs when booting a program? (thinking about one-click install full node distros for example)