Skip to content

fix(#54): add named route, update view and controllers - #57

Merged
romanzipp merged 8 commits into
romanzipp:masterfrom
huzaifaarain:master
Mar 5, 2021
Merged

romanzipp merged 8 commits into
romanzipp:masterfrom
huzaifaarain:master

Conversation

@huzaifaarain

@huzaifaarain huzaifaarain commented Mar 3, 2021 •

Copy link
Copy Markdown
Contributor
  • Updated all routes using Name Routes
  • Removed action() and added route() function in views
  • Removed action() and added route() function in controllers

Fixes #54

@sabinico sabinico left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and working fine in Laravel 5.8

Comment thread src/Controllers/DeleteMonitorController.php Outdated
Comment thread src/Controllers/PurgeMonitorsController.php Outdated
Comment thread src/Routes/QueueMonitorRoutes.php Outdated
Comment thread src/Routes/QueueMonitorRoutes.php Outdated
Comment thread src/Routes/QueueMonitorRoutes.php Outdated
Comment thread views/jobs.blade.php Outdated
Comment thread views/jobs.blade.php Outdated
@romanzipp

Copy link
Copy Markdown
Owner

I've made some adjustments to the route prefixes by adding :: as prefix separator to indicate that these routes are package provided and changed the prefix to queue-monitor

huzaifaarain and others added 7 commits March 5, 2021 09:00
Co-authored-by: Roman Zipp <ich@ich.wtf>
Co-authored-by: Roman Zipp <ich@ich.wtf>
Co-authored-by: Roman Zipp <ich@ich.wtf>
Co-authored-by: Roman Zipp <ich@ich.wtf>
Co-authored-by: Roman Zipp <ich@ich.wtf>
Co-authored-by: Roman Zipp <ich@ich.wtf>
Co-authored-by: Roman Zipp <ich@ich.wtf>
@romanzipp

Copy link
Copy Markdown
Owner

Thanks!

@romanzipp
romanzipp merged commit 9616e68 into romanzipp:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action App\Http\Controllers\romanzipp\QueueMonitor\Controllers\PurgeMonitorsController not defined

3 participants