Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Use *log.Logger instead of io.Writer for logging #19

Closed
KernelPryanic opened this issue May 8, 2018 · 1 comment
Closed

Use *log.Logger instead of io.Writer for logging #19

KernelPryanic opened this issue May 8, 2018 · 1 comment
Assignees
Labels
enhancement A general enhancement proposal
Milestone

Comments

@KernelPryanic
Copy link
Collaborator

Use *log.Logger instead of io.Writer for logging, it allows the library user to set custom logging flags and prefixes. Currently this is not possible and the default prefixes are used like: WARNING: and ERROR: , though we'd like to differentiate between error logs produced by webwire and our own code.

@romshark romshark self-assigned this May 9, 2018
@romshark romshark added the enhancement A general enhancement proposal label May 9, 2018
@romshark romshark added this to the v1.0.0 rc1 milestone May 9, 2018
@romshark
Copy link
Owner

romshark commented May 9, 2018

As of commit #a12e9d6 *log.Logger are now passed as log targets in both the client and the server options. When no loggers are passed then default loggers to stdout/stderr are created.

@romshark romshark closed this as completed May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A general enhancement proposal
Projects
None yet
Development

No branches or pull requests

2 participants