Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastboot compatibility #1

Merged
merged 3 commits into from Feb 10, 2016
Merged

Fastboot compatibility #1

merged 3 commits into from Feb 10, 2016

Conversation

ronco
Copy link
Owner

@ronco ronco commented Feb 4, 2016

Manually construct head component (for fastboot).

Instantiating the component automatically through the container throws an exception under fastboot because a new DomHelper is created which relies upon document.

For full functionality we will also need an index.html placeholder, and updates to ember-fastboot-server to serialize the head component.

);
component.appendTo('head');
const componentFactory =
instance.__container__.lookupFactory('component:head-content');
Copy link
Collaborator

@rwjblue rwjblue Feb 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use instance._lookupFactory instead

Copy link
Owner Author

@ronco ronco Feb 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Feb 4, 2016

Left a few nit-picks, but looks good otherwise.

@ronco
Copy link
Owner Author

@ronco ronco commented Feb 5, 2016

Thanks! It'll be a couple days till I can work on this again, but I'll try
to have it all buttoned up before next weeks hangout.
On Thu, Feb 4, 2016 at 4:35 PM Robert Jackson notifications@github.com
wrote:

Left a few nit-picks, but looks good otherwise.


Reply to this email directly or view it on GitHub
#1 (comment).

@ronco ronco force-pushed the feature/fastboot-compat branch 3 times, most recently from 01854de to 344504f Compare Feb 9, 2016
@ronco ronco force-pushed the feature/fastboot-compat branch from 344504f to 673de64 Compare Feb 10, 2016
If FastBoot isn't found in the sandbox go ahead and straightup lookup
the component, this keeps things compatible in older ember versions.
ronco added a commit that referenced this issue Feb 10, 2016
@ronco ronco merged commit a32b5a0 into master Feb 10, 2016
2 checks passed
@ronco ronco deleted the feature/fastboot-compat branch Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants