Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourcesScanner doesn't work since 0.9.10 #102

Closed
mkgl opened this issue Nov 16, 2015 · 2 comments
Closed

ResourcesScanner doesn't work since 0.9.10 #102

mkgl opened this issue Nov 16, 2015 · 2 comments

Comments

@mkgl
Copy link

mkgl commented Nov 16, 2015

Since 0.9.10 ResourcesScanner no longer works and will return all .class resources along. Filtering in acceptsInput in there has become useless since it's OR-ed with acceptResult, whose resultFilter is Predicates.alwaysTrue() by default.

Culprit commit is the following:
2f3294c FilterBuilder check for matches for each resource on both file relative path (with /) and fqn (with .)

I never knew what was the motivation to replace slashes with dots in the first place (producing fqns over paths); I agree we should definitely be able to filter on paths. Just not sure it was the rightest way to introduce that (especially with respect to the evaluation overhead which others reported).

If time allows I'd gladly contribute something, but I think a first step would be to revert what has happened there anyway. Any opinion or rationale?

Cheers,
Mika

@jonenst
Copy link

jonenst commented Aug 30, 2019

Just found the same bug today, exactly as mkgl said:

Since 0.9.10 ResourcesScanner no longer works and will return all .class resources along. Filtering in acceptsInput in there has become useless since it's OR-ed with acceptResult, whose resultFilter is Predicates.alwaysTrue() by default.

@ronmamo
Copy link
Owner

ronmamo commented Jan 12, 2020

works after 0.9.10

@ronmamo ronmamo closed this as completed Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants