Replaced log4j dependency with SLF4J #4

Open
wants to merge 4 commits into
from

Projects

None yet

2 participants

@fragnemesis
Contributor

I don't use log4j, so I needed to replace the logging dependency with something that would work for me. SLF4J is a great library for creating a nice API that can be used as a facade for a multitude of logging frameworks. It's highly recommended as a dependency replacement for log4j.

Great work on the Expect implementation, btw! I looked at the other Expect Java libraries before coming here, and neither of them worked the way that I wanted. Your implementation is much simpler, making it easier to modify and integrate into other projects.

fragnemesis added some commits Feb 27, 2013
@fragnemesis fragnemesis Replaced log4j dependency with SLF4J
SLF4J is a better dependency for code used in potentially many 
projects, as it doesn't couple a specific logging dependency to 
the shared code.
d54b9c0
@fragnemesis fragnemesis changed log4j dependency to slf4j
Changed documentation to reflect updated dependency on slf4j instead 
of log4j.
41e1696
@ronniedong
Owner

Hello fragnemesis,

Glad you find it useful! As of SLF4J, I always find it hard to use the logging tools... but my projects are using log4j in other places too, so I would keep it like this for now..

Thanks.
Ronnie

fragnemesis added some commits Mar 19, 2013
@fragnemesis fragnemesis Update Expect.java
Changed fields and getters/setters to comply with Java naming conventions.
94ee616
@fragnemesis fragnemesis Fixed timeout int wraparound bug
int is multiplied by 1000 and this value is greater than int.MAX_VALUE, a wraparound will occur resulting in a large negative number.  This will effectively make the timeout end immediately instead of lasting indefinitely.
bfad1d7
@fragnemesis
Owner

tweaked field names to conform to Java naming conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment