Pod corrections + 2 more test files for more explicit direct sub tests #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ron,
I've recently signed up to help contribute to CPAN via the PRC i.e. 'P'ull 'R'equest 'C'hallenge.
I was assigned the GraphViz2 distribution (well, after the first one scaring the bejeezers out of me 'Math::Prime::Util' I asked for a re-assignment) and directed to some helpful ideas on how to make a useful pull request.
I've done the following to generate this current pull request
cd /path/to/GraphViz2
find ./ -name "*.p[lm]" -exec podchecker {} \;
I found 2 errors, a typo and a head hierarchy clash.
cd /path/to/GraphViz2
cover -test
I'm in doubt as to whether GraphViz2 requires direct sub checking as the scripts/ tests usable examples rather than single function calls. However I've created 2 more specific test files that do just this, so the final coverage.html shows a much greater percentage covering of subs. NB without fully understanding what the tests are doing I've added minimal arguments to these subs so the sub called executes without error. The new test files are below and will run with
make test
orcover -test
t/test_new.t
t/test_more_methods.t
Please let me know what you think