Correct Roo::VERSION #148
Closed
Correct Roo::VERSION #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| module Roo | |||
|
|
|||
| VERSION = '1.12.1' | |||
| VERSION = File.read(File.join(__dir__, "../VERSION")) rescue "0.0.0-unknown" | |||
There was a problem hiding this comment.
Could you remove the rescue? If the file is missing it should fail noisily so we know about it.
|
Why not remove this file and not create |
|
Entirely possible (and my preferred route; I'm not a big fan of Jeweler) but changing something as basic as the build tool is something I'd like to leave to the maintainer - it has impact beyond just the state of the code! |
|
Switched to bundler's gem builder - thanks for the suggestion @simonoff |
Empact
added a commit
that referenced
this pull request
Nov 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured out how fix #147 easily :)