Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle url with long query params (ex. S3 secure url) #302

Merged
merged 1 commit into from Feb 18, 2016

Conversation

juggy
Copy link
Contributor

@juggy juggy commented Feb 18, 2016

When you have a really long url with query params, you get this error message:

"File name too long @ dir_s_mkdir - /tmp/roo_Mate%CC%81riaux.xlsx?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJ4PG27V6H4DDKG3Q%2F20160218%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20160218T215714Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Signature=37ca8bd46c24e289ef7aa742be23617de4b70ce56fbc457415a73b7c56226c7f20160218-1164-7230qc"

This fix makes sure to ignore the query params part.

@stevendaniels
Copy link
Contributor

Thanks @juggy!

Fixes #301.

stevendaniels added a commit that referenced this pull request Feb 18, 2016
Handle url with long query params (ex. S3 secure url)
@stevendaniels stevendaniels merged commit bdf777f into roo-rb:master Feb 18, 2016
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Mar 10, 2016
## [2.3.2] 2016-02-18
### Fixed
- Handle url with long query params (ex. S3 secure url) [302](roo-rb/roo#302)
- Allow streaming for Roo::CSV [297](roo-rb/roo#297)
- Export Fixnums to Added csv [295](roo-rb/roo#295)
- Removed various Ruby warnings [289](roo-rb/roo#289)
- Fix incorrect example result in Readme.md [293](roo-rb/roo#293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants