Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Avoid using Nokogiri::XML::Node#attribute #484

Conversation

@chopraanmol1
Copy link
Member

chopraanmol1 commented Jan 10, 2019

Avoid using Nokogiri::XML::Node#attribute and Nokogiri::XML::Node#attributes for Roo::Excelx

Nokogiri::XML::Node#[] is more performant and easier to read.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage decreased (-0.01%) to 94.169% when pulling 54b8262 on chopraanmol1:refactor_avoid_nokogiri_node_attribute into 907c178 on roo-rb:master.

4 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage decreased (-0.01%) to 94.169% when pulling 54b8262 on chopraanmol1:refactor_avoid_nokogiri_node_attribute into 907c178 on roo-rb:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage decreased (-0.01%) to 94.169% when pulling 54b8262 on chopraanmol1:refactor_avoid_nokogiri_node_attribute into 907c178 on roo-rb:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage decreased (-0.01%) to 94.169% when pulling 54b8262 on chopraanmol1:refactor_avoid_nokogiri_node_attribute into 907c178 on roo-rb:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage decreased (-0.01%) to 94.169% when pulling 54b8262 on chopraanmol1:refactor_avoid_nokogiri_node_attribute into 907c178 on roo-rb:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage decreased (-0.009%) to 94.178% when pulling 73ba960 on chopraanmol1:refactor_avoid_nokogiri_node_attribute into baf0fb6 on roo-rb:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage decreased (-0.01%) to 94.169% when pulling 54b8262 on chopraanmol1:refactor_avoid_nokogiri_node_attribute into 907c178 on roo-rb:master.

@chopraanmol1 chopraanmol1 force-pushed the chopraanmol1:refactor_avoid_nokogiri_node_attribute branch from 54b8262 to 7c71c39 Jan 11, 2019
…Node#attributes for Roo::Excelx

Nokogiri::XML::Node#[] is more performant and easier to read.
@chopraanmol1 chopraanmol1 force-pushed the chopraanmol1:refactor_avoid_nokogiri_node_attribute branch from 7c71c39 to 73ba960 Jan 11, 2019
@chopraanmol1 chopraanmol1 merged commit aee36f2 into roo-rb:master Jan 11, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.009%) to 94.178%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chopraanmol1 chopraanmol1 deleted the chopraanmol1:refactor_avoid_nokogiri_node_attribute branch Jan 11, 2019
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 20, 2019
pkgsrc change: add "USE_LANGUAGES= # none".

##  [2.8.0] 2019-01-18
### Fixed
- Fixed inconsistent column length for CSV [375](roo-rb/roo#375)
- Fixed formatted_value with `%` for Excelx [416](roo-rb/roo#416)
- Improved Memory consumption and performance [434](roo-rb/roo#434) [449](roo-rb/roo#449) [454](roo-rb/roo#454) [456](roo-rb/roo#456) [458](roo-rb/roo#458) [462](roo-rb/roo#462) [466](roo-rb/roo#466)
- Accept both Transitional and Strict Type for Excelx's worksheets [441](roo-rb/roo#441)
- Fixed ruby warnings [442](roo-rb/roo#442) [476](roo-rb/roo#476)
- Restore support for URL as file identifier for CSV [462](roo-rb/roo#462)
- Fixed missing location for Excelx's links [482](roo-rb/roo#482)

### Changed / Added
- Drop support for ruby 2.2.x and lower
- Updated rubyzip version for fixing security issue. Now minimal version is 1.2.1
- Roo::Excelx::Coordinate now inherits Array [458](roo-rb/roo#458)
- Improved Roo::HeaderRowNotFoundError exception's message [461](roo-rb/roo#461)
- Added `empty_cell` option which by default disable allocation for Roo::Excelx::Cell::Empty [464](roo-rb/roo#464)
- Added support for variable number of decimals for Excelx's formatted_value [387](roo-rb/roo#387)
- Added `disable_html_injection` option to disable html injection for shared string in `Roo::Excelx` [392](roo-rb/roo#392)
- Added image extraction for Excelx [414](roo-rb/roo#414) [397](roo-rb/roo#397)
- Added support for `1e6` as scientific notation for Excelx [433](roo-rb/roo#433)
- Added support for Integer as 0 based index for Excelx's `sheet_for` [455](roo-rb/roo#455)
- Extended `no_hyperlinks` option for non streaming Excelx methods [459](roo-rb/roo#459)
- Added `empty_cell` option to disable Roo::Excelx::Cell::Empty allocation for Excelx [464](roo-rb/roo#464)
- Added support for Integer with leading zero for Roo:Excelx [479](roo-rb/roo#479)
- Refactored Excelx code [453](roo-rb/roo#453) [477](roo-rb/roo#477) [483](roo-rb/roo#483) [484](roo-rb/roo#484)

### Deprecations
- Roo::Excelx::Sheet#present_cells is deprecated [454](roo-rb/roo#454)
- Roo::Utils.split_coordinate is deprecated [458](roo-rb/roo#458)
- Roo::Excelx::Cell::Base#link is deprecated [457](roo-rb/roo#457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.