Skip to content

Update to the roodi.yml file to parse under Psych #11

Merged
merged 1 commit into from Jan 25, 2013
@aselder
aselder commented Oct 5, 2011

In Ruby 1.9, the psych yaml parser barfs on the roodi.yml file.

I've just reformatted to parse correctly under both Psych and Syck.

@yob
yob commented Nov 3, 2011

+1

@bublik
bublik commented Nov 17, 2011

+1
/home/wr/.rvm/gems/ruby-1.9.3-p0/gems/roodi-2.1.0/lib/roodi/core/../../../roodi.yml): couldn't parse YAML at line 3 column 60 (Psych::SyntaxError)

cat /home/wr/.rvm/gems/ruby-1.9.3-p0/gems/roodi-2.1.0/lib/roodi/core/../../../roodi.yml
AssignmentInConditionalCheck: { }
CaseMissingElseCheck: { }
ClassLineCountCheck: { line_count: 300 }
ClassNameCheck: { pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/ }
ClassVariableCheck: { }
CyclomaticComplexityBlockCheck: { complexity: 4 }
CyclomaticComplexityMethodCheck: { complexity: 8 }
EmptyRescueBodyCheck: { }
ForLoopCheck: { }
MethodLineCountCheck: { line_count: 20 }
MethodNameCheck: { pattern: !ruby/regexp /^

@Daan-
Daan- commented Jan 7, 2012

+1

@quamen
quamen commented Feb 29, 2012

👍

@bakongo
bakongo commented Feb 29, 2012

+1, I'm getting the same error: couldn't parse YAML at line 4 column 60

@l0b0
l0b0 commented Mar 26, 2012

+1. Trace:

/home/user/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:154:in `parse': (/home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/lib/roodi/core/../../../roodi.yml): couldn't parse YAML at line 3 column 60 (Psych::SyntaxError)
    from /home/user/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:154:in `parse_stream'
    from /home/user/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:125:in `parse'
    from /home/user/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:112:in `load'
    from /home/user/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:229:in `load_file'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/lib/roodi/core/runner.rb:71:in `load_checks'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/lib/roodi/core/runner.rb:22:in `check'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/lib/roodi/core/runner.rb:35:in `check_file'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/bin/roodi:14:in `block (2 levels) in <top (required)>'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/bin/roodi:14:in `each'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/bin/roodi:14:in `block in <top (required)>'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/bin/roodi:13:in `each'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/gems/roodi-2.1.0/bin/roodi:13:in `<top (required)>'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/bin/roodi:19:in `load'
    from /home/user/.rvm/gems/ruby-1.9.3-p0@project/bin/roodi:19:in `<main>'
@jmthomas

+1 same issue. Replaced yml file with Andrew's updated file and it works.

@noahgibbs

+1, same issue

@htw-rails

+1, same issue.

@Wolg
Wolg commented Jul 26, 2012

+1, same issue.

@AVGP
AVGP commented Oct 1, 2012

+1

@dimascyriaco

+1 too.

@robmack
robmack commented Nov 28, 2012

+1

@krainboltgreene

Why hasn't this been merged?

@martinjandrews martinjandrews merged commit a019826 into roodi:master Jan 25, 2013
@kbrock kbrock referenced this pull request in ManageIQ/manageiq Sep 20, 2014
Merged

upstream gem simplecov-rcov-text and remove roodi #646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.