Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version is incorrect during a ceph upgrade #2353

Closed
travisn opened this issue Dec 8, 2018 · 2 comments

Comments

Projects
1 participant
@travisn
Copy link
Member

commented Dec 8, 2018

Is this a bug report or feature request?

  • Bug Report

Deviation from expected behavior:
When a cluster orchestration is started, the version of the ceph image is determined by launching the image and getting the major version name from the output of ceph --version. When the crd is later updated with the intention of upgrading, the major version is correctly detected, but then is not updated in memory.

For example, if updating the crd to nautilus from mimic, the messages are seen in the operator log:

2018-12-08 04:36:45.227659 I | op-cluster: the ceph version changed. detecting the new image version...
2018-12-08 04:36:45.241504 I | op-k8sutil: waiting for job rook-ceph-detect-version to complete...
2018-12-08 04:36:50.409846 I | op-cluster: detected ceph version nautilus for image ceph/daemon-base:master
2018-12-08 04:36:50.409882 W | op-cluster: overriding ceph version to mimic specified in the CRD

The last message is incorrect. It should apply "nautilus" as detected, instead of retaining "mimic".

Expected behavior:
The major version should always be accurate in order to perform the orchestration steps.

How to reproduce it (minimal and precise):

Environment:

  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Cloud provider or hardware configuration:
  • Rook version (use rook version inside of a Rook Pod):
  • Kubernetes version (use kubectl version):
  • Kubernetes cluster type (e.g. Tectonic, GKE, OpenShift):
  • Storage backend status (e.g. for Ceph use ceph health in the Rook Ceph toolbox):
@travisn

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

Reopening for backport

@travisn travisn reopened this Dec 17, 2018

@travisn travisn self-assigned this Dec 17, 2018

@travisn travisn added this to To do in v0.9 via automation Dec 17, 2018

@travisn travisn moved this from To do to In progress in v0.9 Dec 17, 2018

@travisn travisn moved this from In progress to In Review in v0.9 Dec 17, 2018

@travisn

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

Backported with #2390

@travisn travisn closed this Dec 17, 2018

v0.9 automation moved this from In Review to Done Dec 17, 2018

@travisn travisn moved this from Done to In Review in v0.9 Dec 17, 2018

@jbw976 jbw976 moved this from In Review to Done in v0.9 Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.