csi: change the fsgrouppolicy for CephFS driver to "File" mode

[humblec]

At present the CephFS CSI driver works with default mode ie,
ReadWriteOncewithFsType. However File type is more apt for
the CephFS CSI driver and this commit bring that change. The
similar change is also introduced in ceph csi driver here:

ceph/ceph-csi#3204

considering the File mode has been GAd in 1.23 kubernetes version
and also we are lifting one of the problematic code path in this
area via Ceph CSI driver changes, it is good to move the
fsgrouppolicy to File.

Signed-off-by: Humble Chirammal hchiramm@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
• Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next minor release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[humblec]

Cc @travisn

[travisn]

considering the File mode has been GAd in 1.23 kubernetes version

Are there any concerns with File mode before it GA'd? Just wanting to confirm if it's really a good option before 1.23.

[humblec]

considering the File mode has been GAd in 1.23 kubernetes version

Are there any concerns with File mode before it GA'd? Just wanting to confirm if it's really a good option before 1.23.

Not that I am aware of. afaict, It looked to be on spot since its introduction. The feature gate got enabled in 1.20 by default where it was alpha in 1.19. considering we are falling back to v1beta1 driver in that version , we are good there as well. @travisn

[travisn]

@humblec Do we need ceph/ceph-csi#3204 in a csi release before we merge this?

[humblec]

@humblec Do we need ceph/ceph-csi#3204 in a csi release before we merge this?

@travisn true.. its good to have it in before this . However unfortunately that PR in merge queue for last 2 weeks with CI failing spuriously, pretty much the same case with all other PRs in the CSI repo !! Will notify once the CI passes and merged..

[humblec]

@travisn jfyi , finally its merged..

[travisn]

@travisn jfyi , finally its merged..

Ok, when is the next ceph-csi release planned? I assume we need to wait for that before merging this?

[humblec]

@travisn jfyi , finally its merged..

Ok, when is the next ceph-csi release planned? I assume we need to wait for that before merging this?

@travisn it was planned a couple of weeks back, however on further discussion to align with odf release it has been postponed to 3rd week of August. So we can wait till then.

Additionally, I was thinking, cant we keep Rook master in parity or consuming canary images of ceph csi driver ? and while we cut the release of rook, may be tag the csi image to latest available version ? which also allow us to go on the edge and correct issues without a CSI release ...etc ?

[travisn]

Per discussion with csi team, we will plan on keeping the csi version label even in rook master, and we can add a daily CI test against the csi canary tag.

[humblec]

Per discussion with csi team, we will plan on keeping the csi version label even in rook master, and we can add a daily CI test against the csi canary tag.

@travisn considering Ceph CSI 3.7 is out can we please merge this ?

[travisn]

Per discussion with csi team, we will plan on keeping the csi version label even in rook master, and we can add a daily CI test against the csi canary tag.

@travisn considering Ceph CSI 3.7 is out can we please merge this ?

@humblec Remind me, what happens if this File setting is applied and a previous version of ceph-csi (e.g. 3.6) is deployed? Do we need a version check to change it just like for K8s 1.19?

[humblec]

Per discussion with csi team, we will plan on keeping the csi version label even in rook master, and we can add a daily CI test against the csi canary tag.

@travisn considering Ceph CSI 3.7 is out can we please merge this ?

@humblec Remind me, what happens if this File setting is applied and a previous version of ceph-csi (e.g. 3.6) is deployed? Do we need a version check to change it just like for K8s 1.19?

@travisn I dont anticipate an issue if its operating on file + 3.6 as were opening full permission on mount in that version. Additionally, 3.6 driver deployment should also bring its own csiDriver object.

[humblec]

Thanks @travisn 👍