Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Remove unnecessary env vars from pod specs #11331

Merged
merged 1 commit into from Dec 5, 2022
Merged

core: Remove unnecessary env vars from pod specs #11331

merged 1 commit into from Dec 5, 2022

Conversation

travisn
Copy link
Member

@travisn travisn commented Nov 18, 2022

Description of your changes:
The fsid, username, and user secrets were from legacy and no longer needed on the osd daemon or mon pods. This removes the unnecessary/legacy env vars from the pod specs.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@travisn
core: remove unnecessary env vars from pod specs
33e824a 
The fsid, username, and user secrets were from legacy and no
longer needed on the osd daemon or mon pods. This removes the
unnecessary env vars from the pod specs.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn mentioned this pull request Nov 19, 2022
Closed
@satoru-takeuchi satoru-takeuchi merged commit 0e10d97 into rook:master Dec 5, 2022
50 checks passed
@travisn travisn deleted the remove-env-vars branch December 7, 2022 15:11
@travisn travisn mentioned this pull request Dec 13, 2022
Merged
7 tasks
@mergify mergify bot mentioned this pull request Dec 15, 2022
Merged
@travisn travisn mentioned this pull request Dec 15, 2022
Merged
travisn added a commit that referenced this pull request Dec 15, 2022
@travisn
Merge pull request #11447 from rook/mergify/bp/release-1.10/pr-11331
b8df9df 
core: Remove unnecessary env vars from pod specs (backport #11331)
@travisn travisn mentioned this pull request Dec 15, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoru-takeuchi satoru-takeuchi satoru-takeuchi approved these changes

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

Assignees
No one assigned
Labels
backport-release-1.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisn @satoru-takeuchi