New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix operator app label #2520

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@anarcat
Copy link
Contributor

anarcat commented Jan 18, 2019

Description of your changes:

In our 0.9 rook deployment, the app label assigned to the operator is rook-ceph-operator which was incorrectly speficied in the documentation:

$ kubectl describe pod/rook-ceph-operator-765bcd58b-6rr2q | grep app=
Labels:             app=rook-ceph-operator

Here's where the app label is defined:

Which issue is resolved by this Pull Request:

I didn't bother opening an issue for such a minor problem.

Checklist:

  • Documentation has been updated, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary. (N/A)
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary. (N/A)
  • Code generation (make codegen) has been run to update object specifications, if necessary. (N/A)
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md

[skip ci]

@travisn
Copy link
Member

travisn left a comment

Thanks for catching this issue!

@travisn

This comment has been minimized.

Copy link
Member

travisn commented Jan 18, 2019

Before merge you'll just need to edit your commit to be compliant with the DCO build check. See the "details" link next to the DCO.

@anarcat

This comment has been minimized.

Copy link
Contributor Author

anarcat commented Jan 18, 2019

sigh. i just did an edit here on github... that CLA stuff is really annoying, but I'll pull and recommit locally...

fix operator app label
In our 0.9 rook deployment, the `app` label assigned to the operator is `rook-ceph-operator` which was incorrectly speficied in the documentation:

```
$ kubectl describe pod/rook-ceph-operator-765bcd58b-6rr2q | grep app=
Labels:             app=rook-ceph-operator
```

Signed-off-by: Antoine Beaupré <anarcat@debian.org>

@anarcat anarcat force-pushed the anarcat:patch-1 branch from 9d07ce3 to 7271f7d Jan 18, 2019

@jbw976

jbw976 approved these changes Jan 18, 2019

@jbw976 jbw976 merged commit 1a1ffdd into rook:master Jan 18, 2019

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@anarcat anarcat deleted the anarcat:patch-1 branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment