fix operator app label #2520
Merged
fix operator app label #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
approved these changes
Jan 18, 2019
|
Before merge you'll just need to edit your commit to be compliant with the DCO build check. See the "details" link next to the DCO. |
|
sigh. i just did an edit here on github... that CLA stuff is really annoying, but I'll pull and recommit locally... |
In our 0.9 rook deployment, the `app` label assigned to the operator is `rook-ceph-operator` which was incorrectly speficied in the documentation: ``` $ kubectl describe pod/rook-ceph-operator-765bcd58b-6rr2q | grep app= Labels: app=rook-ceph-operator ``` Signed-off-by: Antoine Beaupré <anarcat@debian.org>
jbw976
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
In our 0.9 rook deployment, the
applabel assigned to the operator isrook-ceph-operatorwhich was incorrectly speficied in the documentation:Here's where the app label is defined:
rook/cluster/charts/rook-ceph/templates/deployment.yaml
Line 17 in 84ad5af
Which issue is resolved by this Pull Request:
I didn't bother opening an issue for such a minor problem.
Checklist:
make codegen) has been run to update object specifications, if necessary. (N/A)[skip ci]